This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Fix 32-bit getcwd() on filesystems with 64-bit inodes.

On Tue, Feb 27, 2018 at 11:33 AM, Nick Alcock <> wrote:
>>> -#if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_2)
>>> +#  if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_2)
>> The indentation is done with one extra space.
> We are already inside one level of #if here: #ifndef _DIRENT_H at the
> top. There is a probable error there: # ifndef _ISOMAC is followed by
> no identation change at all, so frankly I have no *idea* what level is
> appropriate. Perhaps two, perhaps three, certainly not one.

The policy as I understand it is that every level of #if nesting
should increase preprocessor-directive indentation by one space,
*except* for multiple-include guards (the #ifndef _DIRENT_H).

If the file is internally inconsistent, please fix it up as a separate
commit.  Corrections to indentation (and other corrections that only
change white space) do not require prior review - just post the patch
and then check it in.  You do need to add a ChangeLog entry, but it
just needs to say "* whatever.h: Fix indentation."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]