This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch v3 10/14] [BZ #14095] update collation data from Unicode / ISO 14651


On 02/23/2018 02:24 AM, Mike FABIAN wrote:
> From 6bef2c2ea41775073a0ca8dfe4be6969488447f4 Mon Sep 17 00:00:00 2001
> From: Mike FABIAN <mfabian@redhat.com>
> Date: Fri, 15 Dec 2017 07:19:45 +0100
> Subject: [PATCH 10/14] Fix posix/bug-regex5.c test case, adapt to
>  iso14651_t1_common upate
> 
> This test case tests how many collating elements are defined in
> da_DK.ISO-8859-1 locale. The da_DK locale source defines 4:
> 
> collating-element <A-A> from "<U0041><U0041>"
> collating-element <A-a> from "<U0041><U0061>"
> collating-element <a-A> from "<U0061><U0041>"
> collating-element <a-a> from "<U0061><U0061>"
> 
> The new iso14651_t1_common file defines more collating elements, two
> of them are in the ISO-8859-1 range:
> 
> collating-element <U004C_00B7> from "<U004C><U00B7>" % decomposition of LATIN CAPITAL LETTER L WITH MIDDLE DOT
> collating-element <U006C_00B7> from "<U006C><U00B7>" % decomposition of LATIN SMALL LETTER L WITH MIDDLE DOT
> 
> So the total count is now 6 instead of 4.
> 
> 	* posix/bug-regex5.c: Fix test case because with the new
>         iso14651_t1_common file, the da_DK locale now has 6 collating elements
>         in the ISO-8859-1 range instead of 4 with the old iso14651_t1_common
>         file.
> ---
>  posix/bug-regex5.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

LGTM. Annoying how much specific data we encode in the tests.
I wonder if we even need to look for a specific number of collation
elements. Either way this is OK.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]