This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: riscv: fmax/fmin sNaN fix


On 02/21/2018 04:24 PM, DJ Delorie wrote:
> 
> "Carlos O'Donell" <carlos@redhat.com> writes:
>> Patch review includes review of the commit messages for factual accuracy.
> 
> Please review the original changelog entry then ;-)

The ChangeLog entry is not the same as the commit message.

A detailed explanation should become the body of the commit message for your patch.

>> 	* sysdeps/riscv/rvd/s_fmax.c (__fmax): Handle sNaNs correctly.
>> 	* sysdeps/riscv/rvd/s_fmin.c (__fmin): Likewise.
>> 	* sysdeps/riscv/rvf/s_fmaxf.c (__fmaxf): Likewise.
>> 	* sysdeps/riscv/rvf/s_fminf.c (__fminf): Likewise.
> 
> That's actually functional, and doesn't mention anything about specs,
> should be sufficient.

If there is a release out for RISC-V alrady, then this needs a bug number.

So a meaningful, but minimal commit message would be:
~~~
rsicv: Fix fmax/fmin sNaN issues (Bug XXXXX)

If any input to these functions is a sNaN then the result
should be sNaN, regardless of the input.

See discussions:
https://www.sourceware.org/ml/libc-alpha/2018-02/msg00529.html
~~~

Which is fine.

You also have assumed consensus as a machine maintainer :-)

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]