This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] linux/powerpc: sync sys/ptrace.h with Linux 4.15 [BZ #22433, #22807]


"Dmitry V. Levin" <ldv@altlinux.org> writes:

> The unfortunate consequence of this change is that <sys/ptrace.h> could
> no longer be included after <asm/ptrace.h>, and as <signal.h> leads to
> inclusion of <asm/ptrace.h> on powerpc, <sys/ptrace.h> could no longer
> be included after <signal.h>.

I have proposed a patch [1] to deal with this.

[1] https://sourceware.org/ml/libc-alpha/2018-02/msg00426.html

> +  /* Get all VSX registers of a process.  */
> +  PTRACE_GETVSRREGS = 27,
> +#define PT_GETVSRREGS PTRACE_GETVSRREGS
> +
> +  /* Set all VSX registers of a process.  */
> +  PTRACE_SETVSRREGS = 28,
> +#define PT_SETVSRREGS PTRACE_SETVSRREGS
> +

Shouldn't this have been "the first 32 VSX registers" instead of "all VSX
registers"?

The patch looks good to me with that change, but I ask you to not merge it
until a fix is merged for the build issue.

Thanks!

-- 
Tulio Magno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]