This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 4/5] Post-cleanup 1: move libio.h back out of bits/.

On 06/02/2018 18:10, Zack Weinberg wrote:
> On Tue, Feb 6, 2018 at 11:57 AM, Adhemerval Zanella
> <> wrote:
>> On 05/02/2018 21:34, Zack Weinberg wrote:
>>> In this patch, libio.h moves back out of bits/ into the top level of
>>> the libio subdirectory, and is merged with libio/bits/libio-ldbl.h
>>> (which also used to be installed) and include/libio.h.  Since almost
>>> no files include libio.h directly, this is quite straightforward.
>> LGTM with a possible extra cleanups decribed below.
> ...
>> I think you can cleanup the __cplusplus guards for _IO_FILE as well.
> ...
>> As a side note, I think we can cleanup some definitions required to build it
>> externally:
> Certainly, but again, I don't want to add yet more stuff to this
> patchset and I can't promise to do follow-up work in the near future.
> zw

Alright, I don't think these are blockers for the patch itself, but since
you are touching it (and there is a long time since someone work on this
code) I though you could check this out.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]