This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] libnsl: Turn remaining symbols into compat symbols [BZ #22701]
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Florian Weimer <fweimer at redhat dot com>, "Dmitry V. Levin" <ldv at altlinux dot org>
- Cc: nd at arm dot com, Andreas Schwab <schwab at suse dot de>, libc-alpha at sourceware dot org
- Date: Wed, 31 Jan 2018 11:21:16 +0000
- Subject: Re: [PATCH] libnsl: Turn remaining symbols into compat symbols [BZ #22701]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <20180111150450.56D6B40231FB5@oldenburg.str.redhat.com> <mvmk1w0okrb.fsf@suse.de> <35b432ea-b349-6516-6f4a-18d8061f8947@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 29/01/18 13:32, Florian Weimer wrote:
On 01/29/2018 02:30 PM, Andreas Schwab wrote:
On Jan 11 2018, fweimer@redhat.com (Florian Weimer) wrote:
[BZ #22701]
* include/rpcsvc/nislib.h (__nis_default_ttl): Add
libnsl_hidden_proto.
* include/rpcsvc/yp.h (yp_xdrall): Declare with
libnsl_hidden_proto.
* include/rpcsvc/ypclnt.h (yp_maplist): Likewise.
* nis/Makefile (libnsl-routines): Add nss-default only for
build-obsolete-nsl.
* nis/nis_defaults.c (__nis_default_ttl): Add
libnsl_hidden_nolink_def.
* nis/rpcsvc/ypclnt.h (yp_maplist): Remove #ifdef'ed-out
declaration.
* nis/yp_xdr.c (xdr_ypall): Add libnsl_hidden_nolink_def.
* nis/ypclnt.c (yp_maplist): Likewise.
Ok.
Dmitry, is it okay to sneak this into glibc 2.27? The change is mostly cosmetic; the important change was not installing libnsl.so and
libnsl.a, and that is already on master.
isn't this an internal abi break?
if i install glibc-2.27 on top of an earlier glibc install
without removing the previous libnss_nis.so.2, which references
_nsl_default_nss, then the new libnsl.so.1 will not have that
symbol so old libnss_nis.so.2 no longer works.
either i have to --enable-obsolete-nsl in the new libc or
remove the old libnss_nis.so.2 (and hope nothing needs it)
before i run the new ldconfig.
i thought 'installing over' previous libc is a valid use
(i do this when testing in chroot)