This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Mon, 29 Jan 2018 07:30:30 PST (-0800), joseph@codesourcery.com wrote:
On Fri, 26 Jan 2018, Palmer Dabbelt wrote:+extern ElfW (Addr) la_riscv_gnu_pltenter (ElfW (Sym) *__sym, unsigned int __ndx,You seem to have ended up (in patch series v4, it seems), with spaces after ElfW / GLRO / GL, which are exceptions noted at <https://sourceware.org/glibc/wiki/Style_and_Conventions> to the normal rule about spaces before parentheses, because they logically expand to a single identifier. Please fix this for all ElfW / GLRO / GL calls in this patch series as part of the commit. Do not send a v8 patch series.
Thanks. These are also fixed. I'm going to run a sanity check against linux-4.15 and then commit the port.
Thanks for all your help!
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |