This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v7 06/17] RISC-V: Startup and Dynamic Loading Code

From: Joseph Myers <joseph at codesourcery dot com>
To: Palmer Dabbelt <palmer at dabbelt dot com>
Cc: <libc-alpha at sourceware dot org>
Date: Mon, 29 Jan 2018 15:30:30 +0000
Subject: Re: [PATCH v7 06/17] RISC-V: Startup and Dynamic Loading Code
Authentication-results: sourceware.org; auth=none
References: <20180127035744.10058-1-palmer@dabbelt.com> <20180127035744.10058-7-palmer@dabbelt.com>

On Fri, 26 Jan 2018, Palmer Dabbelt wrote:

> +extern ElfW (Addr) la_riscv_gnu_pltenter (ElfW (Sym) *__sym, unsigned int __ndx,

You seem to have ended up (in patch series v4, it seems), with spaces 
after ElfW / GLRO / GL, which are exceptions noted at 
<https://sourceware.org/glibc/wiki/Style_and_Conventions> to the normal 
rule about spaces before parentheses, because they logically expand to a 
single identifier.

Please fix this for all ElfW / GLRO / GL calls in this patch series as 
part of the commit.  Do not send a v8 patch series.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH v7 06/17] RISC-V: Startup and Dynamic Loading Code
  - From: Palmer Dabbelt

References:
- RISC-V glibc port, v7
  - From: Palmer Dabbelt
- [PATCH v7 06/17] RISC-V: Startup and Dynamic Loading Code
  - From: Palmer Dabbelt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]