This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[hurd,commited 5/7] hurd: fix warning
- From: Samuel Thibault <samuel dot thibault at ens-lyon dot org>
- To: libc-alpha at sourceware dot org
- Cc: Samuel Thibault <samuel dot thibault at ens-lyon dot org>
- Date: Sat, 27 Jan 2018 23:51:00 +0100
- Subject: [hurd,commited 5/7] hurd: fix warning
- Authentication-results: sourceware.org; auth=none
- References: <20180127225102.11373-1-samuel.thibault@ens-lyon.org>
Making `special_profil_failure' both avoids warning "variable
'special_profil_failure' set but not used", and makes it easier to
access with gdb.
* sysdeps/mach/hurd/profil.c (special_profil_failure): Move variable
to global scope.
---
ChangeLog | 2 ++
sysdeps/mach/hurd/profil.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 5dd9e9fcb6..5e62415607 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -29,6 +29,8 @@
MACH_IPC_COMPAT.
* sysdeps/mach/hurd/dl-sysdep.c (_exit): Call LOSE and abort() if
__task_terminate would ever return successfully.
+ * sysdeps/mach/hurd/profil.c (special_profil_failure): Move variable
+ to global scope.
2018-01-27 James Clarke <jrtc27@jrtc27.com>
diff --git a/sysdeps/mach/hurd/profil.c b/sysdeps/mach/hurd/profil.c
index 2fe8f9de56..b3f201b016 100644
--- a/sysdeps/mach/hurd/profil.c
+++ b/sysdeps/mach/hurd/profil.c
@@ -138,6 +138,8 @@ __profil (u_short *sample_buffer, size_t size, size_t offset, u_int scale)
}
weak_alias (__profil, profil)
+static volatile error_t special_profil_failure;
+
/* Fetch PC samples. This function must be very careful not to depend
on Hurd threadvar variables. We arrange that by using a special
stub arranged for at the end of this file. */
@@ -154,7 +156,6 @@ fetch_samples (void)
pc_samples, &nsamples);
if (err)
{
- static volatile error_t special_profil_failure;
static volatile int a, b;
special_profil_failure = err;
--
2.15.1