Re: [PATCH] aarch64: Revert the change of the __reserved member of mcontext_t

[Szabolcs Nagy <szabolcs dot nagy at arm dot com>]

On 24/01/18 11:55, Szabolcs Nagy wrote:
> On 23/01/18 15:16, Florian Weimer wrote:
> > On 01/23/2018 03:35 PM, Szabolcs Nagy wrote:
> > > The uc_mcontext.__reserved member of ucontext_t is a user visible API,
> > > that should not be changed, because this is the only way to access cpu
> > > states of various extensions of linux asm/sigcontext.h, it does not
> > > violate namespace rules either, so revert this part of the commit
> > >
> > > commit 4fa9b3bfe6759c82beb4b043a54a3598ca467289
> > > Commit:     Joseph Myers<joseph@codesourcery.com>
> > >
> > >       Fix mcontext_t sigcontext namespace (bug 21457).
> > >
> > > (In principle the user can type cast &uc_mcontext to struct sigcontext*
> > > to use the linux sigcontext fields, but that's not the existing practice
> > > since mcontext_t used to be a typedef of struct sigcontext.)
> > >
> > > I plan to commit this soon for 2.27 and backport it to 2.26 if there are
> > > no comments.
> >
> > I think this is the right thing to do, but unfortunately, this back-and-forth is a bit painful.
>
> ok, i opened bug 22742 because it's a user visible change.
>
> committed now on 2.27 (will backport it in a day or two).

the problematic commit is not present in 2.26, so
this is not a 2.26 regression, i'm not sure how i
missed that (i checked the git log of 2.26 branch
several times).

so there is no user visible api break, sorry for the noise.