This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH COMMITTED] nptl/tst-thread-exit-clobber: Run with any C++ compiler
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Tue, 16 Jan 2018 13:00:49 -0800
- Subject: Re: [PATCH COMMITTED] nptl/tst-thread-exit-clobber: Run with any C++ compiler
- Authentication-results: sourceware.org; auth=none
- References: <20180116204656.5E701405D5834@oldenburg.str.redhat.com>
On 01/16/2018 12:46 PM, Florian Weimer wrote:
> We do not need thread_local support in the C++11 comiler, and the
> minimum GCC version for glibc has C++11 support (if it has C++ support).
>
> 2018-01-16 Florian Weimer <fweimer@redhat.com>
>
> * nptl/Makefile [$(have-cxx-thread_local)] (tests-unsupported):
> Move tst-thread-exit-clobber ...
> [$(CXX)] (tests-unsupported): ... to here.
>
> diff --git a/nptl/Makefile b/nptl/Makefile
> index a11a25bbff..7940b3d26b 100644
> --- a/nptl/Makefile
> +++ b/nptl/Makefile
> @@ -461,11 +461,11 @@ endif
> ifeq (,$(CXX))
> # These tests require a C++ compiler and runtime.
> tests-unsupported += tst-cancel24 tst-cancel24-static tst-once5 \
> - tst-minstack-throw
> + tst-thread-exit-clobber tst-minstack-throw
> endif
> # These tests require a C++ compiler and runtime with thread_local support.
> ifneq ($(have-cxx-thread_local),yes)
> -tests-unsupported += tst-thread_local1 tst-thread-exit-clobber
> +tests-unsupported += tst-thread_local1
> endif
>
> include ../Rules
>
Thank you for your attention to detail! :-)
--
Cheers,
Carlos.