This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4] dl-load: add memory barrier before updating the next
- From: Maninder Singh <maninder1 dot s at samsung dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "triegel at redhat dot com" <triegel at redhat dot com>, "nd at arm dot com" <nd at arm dot com>
- Cc: PANKAJ MISHRA <pankaj dot m at samsung dot com>, AMIT SAHRAWAT <a dot sahrawat at samsung dot com>, Lalit Mohan Tripathi <lalit dot mohan at samsung dot com>, AKHILESH KUMAR <akhilesh dot k at samsung dot com>, Hakbong Lee <hakbong5 dot lee at samsung dot com>, Vaneet Narang <v dot narang at samsung dot com>
- Date: Mon, 15 Jan 2018 06:09:45 +0000
- Subject: Re: [PATCH v4] dl-load: add memory barrier before updating the next
- Authentication-results: sourceware.org; auth=none
- Cms-type: 105P
- Dkim-filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20180115070652epoutp034457ff5d9750f30e275d0eb50c9bdae5~J6frNXTgA1088610886epoutp03Q
- Dlp-filter: Pass
- References: <5A565C9E.6050209@arm.com> <20171228050519epcms5p20687eaadacef784758d9524cd98aedca@epcms5p2> <CGME20171228050519epcms5p20687eaadacef784758d9524cd98aedca@epcms5p8>
- Reply-to: maninder1 dot s at samsung dot com
Hi Szabolcs,
Thanks for the comment,
>>>[BZ #21349]: race condition between dl_open and rtld lazy symbol resolve.
>>>
>>>Issue Fix: race condition between add_name_to_object & _dl_name_match_p.
>>>One threads calling dlopen which further calls add_name_to_object &
>>>other thread trying to resolve RTLD_LAZY symbols through
>>>_dl_runtime_resolve which further calls.
>>>
>
>this patch needs updated comments and description to
>follow the new concurrency documentation requirements.
>
>the code looks acceptable to me.
>
>i can try to provide comments that are acceptable and
>resubmit the patch for you if you want me to, or you
>can look at the concurrency wiki and try to come up
>with better documentation.
Can you please suggest the coment, I will update that one
and send the new patch, because we have updated the comment as
suggested by you in last mail.
https://sourceware.org/ml/libc-alpha/2017-03/msg00383.html
Or it would be great if you can submit the patch with acceptable comments :) .
We have updated testcase at below BugZilla link
https://sourceware.org/bugzilla/show_bug.cgi?id=21349
--------------------
Thanks and Regards,
Maninder Singh