Re: [PATCH v11 1/5] Implement alternative month names (bug 10871).

["Dmitry V. Levin" <ldv at altlinux dot org>]

On Tue, Jan 09, 2018 at 12:59:21AM +0100, Rafal Luzynski wrote:
> 	[BZ #10871]
> 	* locale/C-time.c: Add alternative month names, define them as the
> 	same as mon explicitly.

* locale/C-time.c (_nl_C_LC_TIME): Add alternative month names.

I don't understand what do you mean by "define them as the same as mon explicitly", though.

> 	* locale/categories.def: alt_mon and wide-alt_mon added.

* locale/categories.def (LC_TIME): Add alt_mon and wide-alt_mon.

> 	* locale/langinfo.h [__USE_GNU]: New public symbols ALTMON_1,
> 	ALTMON_2, ALTMON_3, ALTMON_4, ALTMON_5, ALTMON_6, ALTMON_7,
> 	ALTMON_8, ALTMON_9, ALTMON_10, ALTMON_11, ALTMON_12,
> 	_NL_WALTMON_1, _NL_WALTMON_2, _NL_WALTMON_3, _NL_WALTMON_4,
> 	_NL_WALTMON_5, _NL_WALTMON_6, _NL_WALTMON_7, _NL_WALTMON_8,
> 	_NL_WALTMON_9, _NL_WALTMON_10, _NL_WALTMON_11, _NL_WALTMON_12.

* locale/langinfo.h (__ALTMON_1, __ALTMON_2, __ALTMON_3, __ALTMON_4,
__ALTMON_5, __ALTMON_6, __ALTMON_7, __ALTMON_8, __ALTMON_9, __ALTMON_10,
__ALTMON_11, __ALTMON_12, _NL_WALTMON_1, _NL_WALTMON_2, _NL_WALTMON_3,
_NL_WALTMON_4, _NL_WALTMON_5, _NL_WALTMON_6, _NL_WALTMON_7,
_NL_WALTMON_8, _NL_WALTMON_9, _NL_WALTMON_10, _NL_WALTMON_11,
_NL_WALTMON_12): New enum constants.
[__USE_GNU] (ALTMON_1, ALTMON_2, ALTMON_3, ALTMON_4, ALTMON_5, ALTMON_6,
ALTMON_7, ALTMON_8, ALTMON_9, ALTMON_10, ALTMON_11, ALTMON_12): New
macros.

> 	* locale/programs/ld-time.c: Alternative month names support
> 	added, they are a copy of mon if not specified explicitly.

* locale/programs/ld-time.c (struct locale_time_t): Add alt_mon,
walt_mon, and alt_mon_defined members.
(time_output): Output alt_mon and walt_mon members.
(time_read): Read them, initialize alt_mon_defined.

> 	* locale/programs/locfile-kw.gperf: alt_mon defined.

* locale/programs/locfile-kw.gperf (alt_mon): Define.

> 	* locale/programs/locfile-token.h: tok_alt_mon defined.

* locale/programs/locfile-token.h (tok_alt_mon): New enum constant.

> 	* localedata/tst-langinfo.c: Add tests for the new constants
> 	ALTMON_1 .. ALTMON_12.

* localedata/tst-langinfo.c (map): Add ... (whatever is being added).

> 	* time/Makefile (LOCALES): Add pl_PL.UTF-8 for tests.

* time/Makefile [$(run-built-tests) = yes] (LOCALES): Add pl_PL.UTF-8.

> 	* time/strftime_l.c: %OB format for alternative month names
> 	added.

* time/strftime_l.c (f_altmonth): New macro.
(__strftime_internal): Handle %OB format.

> 	* time/strptime_l.c: Alternative month names also recognized.

* time/strptime_l.c (alt_month_name): New macro.
(__strptime_internal) [_LIBC]: Add ... (whatever is being added).
Handle %OB format.

> 	* time/tst-strptime.c: Add tests to parse different forms of
> 	month names including the new %OB format specifier.

* time/tst-strptime.c (day_tests): Add ... (whatever is being added).

[...]
> --- a/locale/langinfo.h
> +++ b/locale/langinfo.h
> @@ -100,7 +100,8 @@ enum
>    ABMON_12,
>  #define ABMON_12		ABMON_12
>  
> -  /* Long month names.  */
> +  /* Long month names, in the grammatical form used when the month
> +     forms part of a complete date.  */

... when month name is a part of ...?


-- 
ldv

Attachment: signature.asc
Description: PGP signature