This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ #11787] Fix stack guard size accounting


On 01/08/2018 04:41 PM, Szabolcs Nagy wrote:
i knew __pthread_get_minstack was used outside of glibc
but thought removing the guardsize was safe since we
add it back later.

I agree that the patch as posted should be safe because the return value of __pthread_get_minstack does not change.

However, renaming the function would trigger the Rust default implementation, which is PTHREAD_STACK_MIN, and that doesn't take the static TLS size into account. This is why I think we shouldn't do the renaming right now.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]