This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Add malloc micro benchmark
On 01/03/2018 04:12 AM, Wilco Dijkstra wrote:
> DJ Delorie wrote:
>
>> What other tests do is create a second test that just #include's the
>> first test, and set an environment variable in the Makefile specific to
>> that test. Adding an ABI just for a test is a big hammer, although we
>> could discuss adding tcache to mallopt() as a seperate topic.
>
> Yeah but the makefiles are already insanely complex. Adding the new
> benchmark to the makefile took more than 10x as much time as writing
> the test itself...
>
>> I don't have any objection to adding tcache to mallopt (although please
>> add all three tunables if you do), just saying we should discuss it as
>> an ABI change separately.
>
> It doesn't have to be an external ABI, I'd suggest keeping this internal to
> GLIBC to make testing and benchmarking easier.
Don't use mallopt, please make it a tunable then.
The mallopt API already had 2 secret arena options which eventually became
so well used they were baked into the API and had to be made public.
At least with tunables we are allowed to deprecate them.
--
Cheers,
Carlos.