This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5] nptl: Add mutex-internal.h
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 1 Jan 2018 10:38:17 -0200
- Subject: Re: [PATCH 1/5] nptl: Add mutex-internal.h
- Authentication-results: sourceware.org; auth=none
- References: <1514559519-13167-1-git-send-email-adhemerval.zanella@linaro.org> <alpine.DEB.2.20.1801010136531.28505@digraph.polyomino.org.uk>
On 31/12/2017 23:38, Joseph Myers wrote:
> On Fri, 29 Dec 2017, Adhemerval Zanella wrote:
>
>> Checked with a build on affected abis (alpha-linux-gnu, armv7-linux-gnueabihf,
>> hppa-linux-gnu, ia64-linux-gnu, i686-linux-gnu, m68k-linux-gnu,
>> microblaze-linux-gnu, nios2-linux-gnu, powerpc{64le}-linux-gnu,
>> s390{x}-linux-gnu, sh4-linux-gnu, sparc{v9,64}-linux-gnu,
>> tile{pro,gx64}-linux-gnu, x86_64-linux-gnu).
>
> Did you verify that installed stripped shared libraries are unchanged by
> the patch for all those configurations? I think that's important
> validation to do for a change such as this. (The same comment applies to
> patch 2 as well.)
>
No, but I will do the verification. For mutex types I think the current
static assert checks should be suffice to check for any ABI changes,
while for rwlock I think we should add a static assert for the user
visible flag field.