This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 01/19] Avoid race conditions when rebuilding librt.so
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Palmer Dabbelt <palmer at dabbelt dot com>
- Cc: <libc-alpha at sourceware dot org>, <patches at groups dot riscv dot org>
- Date: Mon, 1 Jan 2018 01:58:35 +0000
- Subject: Re: [PATCH v3 01/19] Avoid race conditions when rebuilding librt.so
- Authentication-results: sourceware.org; auth=none
- References: <20171227060534.3998-1-palmer@dabbelt.com> <20171227060534.3998-2-palmer@dabbelt.com>
On Tue, 26 Dec 2017, Palmer Dabbelt wrote:
> `make check' sometimes triggers a rebuild of librt.so using
> nptl/Makefile, which ignores librt's dependence on libpthread. This
> causes the build to blow up when we attempt to run the test suite on
> RISC-V.
OK, please commit, fixed as noted (with an appropriate ChangeLog entry, of
course).
> +# `make check' sometimes triggers a rebuild of librt.so using this Makefile,
Should use neutral vertical quotes now in all new comments, 'make check',
not `'.
> +# which ignores librt's dependence on libpthread
Need '.' at end of comment.
--
Joseph S. Myers
joseph@codesourcery.com