This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] Minimize use of _IO_ and _G_ symbols in public headers.
- From: Zack Weinberg <zackw at panix dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>
- Date: Sun, 31 Dec 2017 17:37:50 -0800
- Subject: Re: [PATCH 2/3] Minimize use of _IO_ and _G_ symbols in public headers.
- Authentication-results: sourceware.org; auth=none
- References: <20171226061052.20907-1-zackw@panix.com> <20171226061052.20907-3-zackw@panix.com> <alpine.DEB.2.20.1801010124210.28505@digraph.polyomino.org.uk>
On Sun, Dec 31, 2017 at 5:27 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Tue, 26 Dec 2017, Zack Weinberg wrote:
>
>> +* The C++ name mangling for interfaces involving the types fpos_t and
>> + fpos64_t has changed.
>
> I don't think this change is appropriate, since it's in no way necessary
> for correctness or to achieve the cleanup. (You could call the types
> "struct _G_fpos_t" and "struct _G_fpos64_t" to avoid changing the mangling
> while still breaking any C code that wrongly uses _G_fpos_t or
> _G_fpos64_t, and still use only the typedefs __fpos_t / __fpos64_t
> directly in glibc.
Good point, I will make that change. The intention was indeed to
catch application code using the _G_ names.
zw