This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Deprecate external use of libio.h and _G_config.h.


On Sun, Dec 24, 2017 at 2:57 AM, Florian Weimer <fw@deneb.enyo.de> wrote:
> * Zack Weinberg:
>
>> +#if !defined _BITS_LIBIO_H && !defined _G_CONFIG_H
>> +#error "Never include <bits/_G_config.h> directly; use <stdio.h> instead."
>> +#endif
>
> I think the #error should be indented.  This applies to two other
> cases as well.
>
> I reviewed the changes and checked that they do not cause material
> changes on i386 (when compiled with -DNDEBUG).  Test suite is clean as
> well.  With the formatting fix above, this should be okay.  Thanks.

Thanks for reviewing.  I made the formatting changes you requested,
expanded the NEWS entry a little, and pushed.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]