This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Deprecate external use of libio.h and _G_config.h.
- From: Zack Weinberg <zackw at panix dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Sun, 24 Dec 2017 09:04:48 -0800
- Subject: Re: [PATCH] Deprecate external use of libio.h and _G_config.h.
- Authentication-results: sourceware.org; auth=none
- References: <20171223052139.12507-1-zackw@panix.com> <874log4cmu.fsf@mid.deneb.enyo.de>
On Sun, Dec 24, 2017 at 2:57 AM, Florian Weimer <fw@deneb.enyo.de> wrote:
> * Zack Weinberg:
>
>> +#if !defined _BITS_LIBIO_H && !defined _G_CONFIG_H
>> +#error "Never include <bits/_G_config.h> directly; use <stdio.h> instead."
>> +#endif
>
> I think the #error should be indented. This applies to two other
> cases as well.
>
> I reviewed the changes and checked that they do not cause material
> changes on i386 (when compiled with -DNDEBUG). Test suite is clean as
> well. With the formatting fix above, this should be okay. Thanks.
Thanks for reviewing. I made the formatting changes you requested,
expanded the NEWS entry a little, and pushed.
zw