This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 06/15] RISC-V: Generic <math.h> and soft-fp Routines

From: Palmer Dabbelt <palmer at dabbelt dot com>
To: joseph at codesourcery dot com
Cc: libc-alpha at sourceware dot org, Andrew Waterman <andrew at sifive dot com>, Darius Rad <darius at bluespec dot com>, dj at redhat dot com
Date: Sat, 23 Dec 2017 16:24:50 -0800 (PST)
Subject: Re: [PATCH v2 06/15] RISC-V: Generic <math.h> and soft-fp Routines
Authentication-results: sourceware.org; auth=none

On Wed, 20 Dec 2017 08:50:48 PST (-0800), joseph@codesourcery.com wrote:

On Tue, 19 Dec 2017, Palmer Dabbelt wrote:

+#ifndef __riscv_flen
+
+#define _FPU_RESERVED 0xffffffff


Missing preprocessor indentation, "# define" etc. inside #if (except for
the #if of a header's multiple-include guard).  Likewise generally in lots
of places in this patch.

+#define _FCLASS_MINF     (1<<0)


GNU style would use (1 << 0) with spaces around <<; likewise elsewhere in
this patch.


OK, sorry about that.  I believe I've gotten all of both of these.

References:
- Re: [PATCH v2 06/15] RISC-V: Generic <math.h> and soft-fp Routines
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]