This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [hurd,commited] hurd: Fix rtld link


Hi Samuel!

On Sun,  3 Sep 2017 04:33:45 +0200, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> --- a/sysdeps/mach/hurd/dl-sysdep.c
> +++ b/sysdeps/mach/hurd/dl-sysdep.c

> +int weak_function
> +__access_noerrno (const char *file, int type)
> +{
> +  errno = ENOSYS;
> +  return -1;
> +}

I just stumbled across this -- OK to push the following?  Note that I
have not tested this.  If approving this, please respond with
"Reviewed-by: NAME <EMAIL>" so that your effort will be recorded.  See
<https://gcc.gnu.org/wiki/Reviewed-by>.

commit 336e16f8e6a588ba048997722a114f9d4462dbdb
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Fri Dec 15 17:00:50 2017 +0100

    Don't set errno in Hurd rtld's __access_noerrno
    
            * sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set
            errno.
    
    Fixes commit 819ea3347e3a30a611488ceeec53650baaeb7961.
---
 sysdeps/mach/hurd/dl-sysdep.c | 1 -
 1 file changed, 1 deletion(-)

diff --git sysdeps/mach/hurd/dl-sysdep.c sysdeps/mach/hurd/dl-sysdep.c
index 2cc342ec8e..5121ce325c 100644
--- sysdeps/mach/hurd/dl-sysdep.c
+++ sysdeps/mach/hurd/dl-sysdep.c
@@ -575,7 +575,6 @@ check_no_hidden(__access_noerrno);
 int weak_function
 __access_noerrno (const char *file, int type)
 {
-  errno = ENOSYS;
   return -1;
 }
 


Grüße
 Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]