This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] add attribute nonstring
On 11/27/2017 04:05 AM, Siddhesh Poyarekar wrote:
On Friday 10 November 2017 11:01 PM, Martin Sebor wrote:
diff --git a/sysdeps/gnu/bits/utmp.h b/sysdeps/gnu/bits/utmp.h
index 2ee11cb..d4885f3 100644
--- a/sysdeps/gnu/bits/utmp.h
+++ b/sysdeps/gnu/bits/utmp.h
@@ -59,9 +59,13 @@ struct utmp
{
short int ut_type; /* Type of login. */
pid_t ut_pid; /* Process ID of login process. */
+ __NONSTRING
char ut_line[UT_LINESIZE]; /* Devicename. */
+ __NONSTRING
char ut_id[4]; /* Inittab ID. */
+ __NONSTRING
char ut_user[UT_NAMESIZE]; /* Username. */
+ __NONSTRING
char ut_host[UT_HOSTSIZE]; /* Hostname for remote login. */
struct exit_status ut_exit; /* Exit status of a process marked
as DEAD_PROCESS. */
This breaks builds with the latest gcc since your commit to warn on
non-string arguments to strlen:
I didn't see any warnings in my x86_64-linux build but there could
be others on targets I don't test. The only problem I do know of
(bug 22447) was fixed last Wednesday.
It would be helpful if you could share some details about the code
that triggers the warning, what target, etc.
Martin