This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Linux: Introduce <bits/mman-shared.h>
On 11/24/2017 09:06 AM, Florian Weimer wrote:
> On 11/24/2017 05:59 PM, Joseph Myers wrote:
>> On Fri, 24 Nov 2017, Florian Weimer wrote:
>>
>>> This header file enables sharing of portable declarations and
>>> definitions across all Linux architectures, including hppa (which does
>>> not use <bits/mman-linux.h>).
>>
>> OK, please commit. But there are more definitions that are the same
>> between bits/mman-linux.h and hppa/bits/mman.h, which it might make sense
>> to move to the new file as well - it looks like PROT_*, MCL_*, MREMAP_*,
>> POSIX_MADV_* are the same. (Some MADV_* are the same, some are
>> different.)
>
> MCL_* current shows considerable variance across architectures. POSIX_MADV_* has an outlier on alpha (POSIX_MADV_DONTNEED is 6 and not 4). I think we should restrict <bits/mman-shared.h> to thinks which are actually shared.
>
> PROT_* and MREMAP_* look the same to me. They could be consolidated.
I had a large patchset to go upstream to reorganize mman.h around
a similar mman-shared.h, there is a mman-common.h upstream but it
is not well used.
You can see my initial suggestion here (oh jeez 2013...)
https://sourceware.org/ml/libc-alpha/2013-03/msg00040.html
--
Cheers,
Carlos.