This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Consolidate link map sorting

From: Florian Weimer <fweimer at redhat dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: libc-alpha at sourceware dot org
Date: Fri, 24 Nov 2017 13:17:37 +0100
Subject: Re: [PATCH] Consolidate link map sorting
Authentication-results: sourceware.org; auth=none
References: <mvmshdnpyyj.fsf@suse.de> <369cac26-b0d2-fffc-9d05-8d0c0cf83388@redhat.com> <mvmh8tynpp5.fsf@suse.de>

On 11/13/2017 04:49 PM, Andreas Schwab wrote:

+  /* We can skip looking for the binary itself which is at the front of
+     the search list.  */
+  _dl_sort_maps (&l_initfini[1], nlist - 1, NULL, false);

I'm still reviewing this. Sorry for taking so long. The followingquestion isn't related to the cleanup as such.

Is the comment really correct? I wonder if skipping the binary itselfhere causes this bug:


  <https://sourceware.org/bugzilla/show_bug.cgi?id=20972>

Thanks,
Florian

References:
- [PATCH] Consolidate link map sorting
  - From: Andreas Schwab
- Re: [PATCH] Consolidate link map sorting
  - From: Florian Weimer
- Re: [PATCH] Consolidate link map sorting
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]