This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH V2] benchtests: Expand range of tests names in schema.json
On Thursday 23 November 2017 04:29 AM, Rodriguez Bahena, Victor wrote:
> Now I remember why I added “=" and “,: There is another test with these
> symbolism its parameters:
>
> Invalid benchmark output: 'stack=1024,guard=1', 'stack=1024,guard=2',
> 'stack=2048,guard=1', 'stack=2048,guard=2' do not match any of the
> regexes: '^[_a-zA-Z0-9.-]*$'
> make[1]: *** [Makefile:215: bench-func] Error 65
>
>
> Full log: https://hastebin.com/menofisuki.pl
>
> From : BENCHSET="bench-pthread bench-math malloc-thread”
>
> Should I add , and = to the regex or fix the name of the test?
I didn't see that go in. I was originally going to suggest replacing it
with - and _ but the current one is far more readable. The original
patch is OK.
Thanks,
Siddhesh