This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Properly compute offsets of note descriptor and next note [BZ #22370]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 20 Nov 2017 05:04:45 -0800
- Subject: Re: [PATCH] Properly compute offsets of note descriptor and next note [BZ #22370]
- Authentication-results: sourceware.org; auth=none
- References: <CAMe9rOoBdhpLRDxbkx3MbOHRpLifa0-SHO46XT9QKYWNPQxMTQ@mail.gmail.com>
On Thu, Nov 16, 2017 at 5:24 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Nov 15, 2017 at 3:03 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Sun, Nov 12, 2017 at 8:03 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> On Nov 12 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote:
>>>
>>>> Data after Elf64_Nhdr is the "name" field which is a 4-byte string, "GNU".
>>>> There is no misalignment.
>>>
>>> That's not what your patch does. You are aligning both the name length
>>> and the data length to a 8 byte boundary, making the note size
>>> unaligned.
>>>
>>
>> You are right. Both glibc and binutils get this wrong. I opened a
>> binutils bug:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=22444
>>
>> I will fix it first and take care of glibc next.
>>
>
> Here is the glibc path.
>
> Any comments?
>
Any comments or objections?
--
H.J.