Re: tst-ttyname failure

[Christian Brauner <christian dot brauner at mailbox dot org>]

On Fri, Nov 17, 2017 at 10:28:44PM +0100, Florian Weimer wrote:
> I need the two attached patches in order to get tst-ttyname to succeed when
> running on Fedora as a non-root user.
> 
> info:  entering chroot 1
> info:    testcase: basic smoketest
> info:      ttyname: PASS {name="/dev/pts/5", errno=0}
> info:      ttyname_r: PASS {name="/dev/pts/5", ret=0, errno=0}
> error: ../sysdeps/unix/sysv/linux/tst-ttyname.c:122: write (setroups,
> "deny"): Operation not permitted
> info:  entering chroot 2
> error: ../sysdeps/unix/sysv/linux/tst-ttyname.c:122: write (setroups,
> "deny"): Operation not permitted
> error: 2 test failures
> 
> I get the same failure when running the test on kernel-3.10.0-768.el7.x86_64
> (there I tested as root).

This is all fine. However, I'm going to send a small patch for
setup_uid_gid_mapping. Unless I'm reading this wrong you still exit with a
failure when you fail to open the setgroups file. However, the setgroups "deny"
restriction and the corresponding file were only added in 3.19. Before that you
could simply write to gid_map. Sending a patch for this.

> 
> This is on top of master with commit
> ce003e5d4cd94c5380699b0dadeaaf825813afbe (support_become_root: Enable file
> creation in user namespaces).  The test failure was present before I pushed
> that change.
> 
> Would you please double-check that they do not break the test on whatever
> distributions you tested on and do not interfere with the test objective?
> 
> Thanks,
> Florian

Attachment: signature.asc
Description: PGP signature