This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] support_create_temp_directory: Align behavior with create_temp_file
- From: Jonathan Nieder <jrnieder at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 17 Nov 2017 09:22:32 -0800
- Subject: Re: [PATCH] support_create_temp_directory: Align behavior with create_temp_file
- Authentication-results: sourceware.org; auth=none
- References: <20171117145550.8B6324469B999@oldenburg.str.redhat.com>
Florian Weimer wrote:
> create_temp_file automatically supplies the test directory and the
> XXXXXX suffix. support_create_temp_directory required the caller to
> specify them, which was confusing.
>
> 2017-11-17 Florian Weimer <fweimer@redhat.com>
>
> * support/temp_file.c (support_create_temp_directory): Use
> test_dir and do not rely on the presence of the XXXXXX suffix.
> * support/temp_file.h (support_create_temp_directory): Update
> comment.
> * support/tst-xreadlink.c (do_test): Adjust.
Makes sense.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>