Re: [PATCH v3 2/3] Consolidate Linux sigprocmask implementation (BZ #22391)

[Rical Jasan <ricaljasan at pacific dot net>]

On 11/16/2017 02:36 AM, Adhemerval Zanella wrote:
> On 15/11/2017 23:16, Rical Jasan wrote:
>> Just one final nit.
>>
>> On 11/15/2017 09:54 AM, Adhemerval Zanella wrote:
>>> diff --git a/manual/signal.texi b/manual/signal.texi
>>> index 9577ff0..4f0ef59 100644
>>> --- a/manual/signal.texi
>>> +++ b/manual/signal.texi
...
>>> @@ -794,6 +795,26 @@ in @ref{Signaling Another Process}.
>>>  The default action is to terminate the process.
>>>  @end deftypevr
>>>  
>>> +@deftypevr Macro int SIGRTMIN
>>> +@deftypevrx Macro int SIGRTMAX
>>> +@standards{POSIX.1, signal.h}
>>> +@cindex real-time signals
>>
>> This @cindex should go above the @deftypevr to ensure the reader lands
>> above the heading.  Much of the time the difference probably won't be
>> noticeable, but it's annoying when you run into that off-chance of it
>> being on some weird boundary.  The Texinfo manual does mention keeping
>> index entries above "visible material" [1].
> 
> Ack, I have changed it locally.
...
>>>  
>>> +@node Internally-Used Signals
>>> +@subsection Internally-Used Signals
>>> +@cindex internally used signals
>>
>> This @cindex, however, must be underneath, as it won't be associated
>> with the correct section otherwise.
> 
> Right, so I presume it is on right position, correct?
Correct.  I just felt a need to point out that this was an exception to
the rule above since I was being nit-picky.  :)

Rical