This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Replace ROUND with ALIGN_UP by p_align [BZ #22370]
On Sun, Nov 12, 2017 at 8:03 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Nov 12 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote:
>
>> Data after Elf64_Nhdr is the "name" field which is a 4-byte string, "GNU".
>> There is no misalignment.
>
> That's not what your patch does. You are aligning both the name length
> and the data length to a 8 byte boundary, making the note size
> unaligned.
>
You are right. Both glibc and binutils get this wrong. I opened a
binutils bug:
https://sourceware.org/bugzilla/show_bug.cgi?id=22444
I will fix it first and take care of glibc next.
Thanks.
--
H.J.