This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] posix: Make tst-getaddrinfo5 an xtest due to Internet requirement [BZ #20826]
On 11/15/2017 09:30 AM, Andreas Schwab wrote:
On Nov 15 2017, Florian Weimer <fweimer@redhat.com> wrote:
On 11/15/2017 08:54 AM, Andreas Schwab wrote:
On Nov 13 2017, fweimer@redhat.com (Florian Weimer) wrote:
We have additional coverage of getaddrinfo through the resolv tests, so
the loss of default test coverage seems acceptable.
2017-11-13 Florian Weimer <fweimer@redhat.com>
[BZ #20826]
Turn posix/tst-getaddrinfo5 into xtest due to Internet requirement.
* posix/Makefile (tests): Remove tst-getaddrinfo5.
(xtests): Add tst-getaddrinfo5.
tst-getaddrinfo4 has the same problem.
Should we turn both into xtests?
Either both or neither.
Fair point. I'm attaching an updated patch.
Thanks,
Florian
These tests need a working Internet connection with DNS.
We have additional coverage of getaddrinfo through the resolv tests, so
the loss of default test coverage seems acceptable.
2017-11-15 Florian Weimer <fweimer@redhat.com>
[BZ #20826]
Turn posix/tst-getaddrinfo4, posix/tst-getaddrinfo5 into xtests
due to Internet requirement.
* posix/Makefile (tests): Remove tst-getaddrinfo4,
tst-getaddrinfo5.
(xtests): Add tst-getaddrinfo4, tst-getaddrinfo5.
diff --git a/posix/Makefile b/posix/Makefile
index 532f2c73c5..87e7ed7f9d 100644
--- a/posix/Makefile
+++ b/posix/Makefile
@@ -90,8 +90,8 @@ tests := test-errno tstgetopt testfnm runtests runptests \
tst-getaddrinfo3 tst-fnmatch2 tst-cpucount tst-cpuset \
bug-getopt1 bug-getopt2 bug-getopt3 bug-getopt4 \
bug-getopt5 tst-getopt_long1 bug-regex34 bug-regex35 \
- tst-pathconf tst-getaddrinfo4 tst-rxspencer-no-utf8 \
- tst-fnmatch3 bug-regex36 tst-getaddrinfo5 \
+ tst-pathconf tst-rxspencer-no-utf8 \
+ tst-fnmatch3 bug-regex36 \
tst-posix_spawn-fd tst-posix_spawn-setsid \
tst-posix_fadvise tst-posix_fadvise64 \
tst-sysconf-empty-chroot tst-glob_symlinks tst-fexecve \
@@ -99,7 +99,7 @@ tests := test-errno tstgetopt testfnm runtests runptests \
tests-internal := bug-regex5 bug-regex20 bug-regex33 \
tst-rfc3484 tst-rfc3484-2 tst-rfc3484-3 \
tst-glob_lstat_compat
-xtests := bug-ga2
+xtests := bug-ga2 tst-getaddrinfo4 tst-getaddrinfo5
ifeq (yes,$(build-shared))
test-srcs := globtest
tests += wordexp-test tst-exec tst-spawn tst-spawn2 tst-spawn3