This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] add attribute nonstring

From: Joseph Myers <joseph at codesourcery dot com>
To: Martin Sebor <msebor at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>, Paul Eggert <eggert at cs dot ucla dot edu>
Date: Tue, 14 Nov 2017 17:58:13 +0000
Subject: Re: [PATCH] add attribute nonstring
Authentication-results: sourceware.org; auth=none
References: <d0432148-24d3-baaa-faf6-b00c33e45103@gmail.com> <alpine.DEB.2.20.1711101752200.5966@digraph.polyomino.org.uk> <11c4caec-df98-12e6-c6f5-cfc95eb8b8d6@gmail.com> <alpine.DEB.2.20.1711102340220.18257@digraph.polyomino.org.uk>

On further investigation of the coding style issue: the normal practice in 
glibc is definitely that attributes (except on function definitions) go 
immediately before the ';' at the end of a declaration (there are e.g. 
various __attribute__ ((__aligned__ (something))) attributes like that on 
struct members).  Also, the normal naming practice in sys/cdefs.h would be 
__attribute_nonstring__ unless there is some reason to deviate from that.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [PATCH] add attribute nonstring
  - From: Martin Sebor
- Re: [PATCH] add attribute nonstring
  - From: Joseph Myers
- Re: [PATCH] add attribute nonstring
  - From: Martin Sebor
- Re: [PATCH] add attribute nonstring
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]