This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] add attribute nonstring
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Steve Ellcey <sellcey at cavium dot com>
- Cc: Martin Sebor <msebor at gmail dot com>, Paul Eggert <eggert at cs dot ucla dot edu>, GNU C Library <libc-alpha at sourceware dot org>, <fweimer at redhat dot com>
- Date: Tue, 14 Nov 2017 16:36:44 +0000
- Subject: Re: [PATCH] add attribute nonstring
- Authentication-results: sourceware.org; auth=none
- References: <06e1ee69-bb30-ff95-42db-2d4b2d7eba7d@gmail.com> <1510594506.5755.119.camel@cavium.com>
On Mon, 13 Nov 2017, Steve Ellcey wrote:
> On Sun, 2017-11-12 at 16:49 -0700, Martin Sebor wrote:
> >
> > PS I still don't see it discussed on the Linux man page but
> > I did find such a requirement on an AIX 6.1 ioctl man page:
> > https://www.ibm.com/support/knowledgecenter/en/ssw_ibm_i_61/apis/ioct
> > l.htm
> >
> > The descriptions of the if_indextoname and if_nametoindex
> > functions specified by RFC 3493 also talk about the name being
> > a nul-terminated string so it looks to me like you are correct
> > and the warning has found a Glibc bug. Yay! :)
>
> I think this is a bug and that if_nametoindex should check for a name
> that is too long. Based on RFC 3493 it would appear that we don't need
> to set errno in this case though I am not sure if that is a correct
> interpretation. I tested this patch:
>
>
> 2017-11-13 Steve Ellcey <sellcey@cavium.com>
>
> * sysdeps/unix/sysv/linux/if_index.c (__if_nametoindex):
> Check if ifname is too long.
Florian, any comments on the proper handling of too-long names here, and
so on how we should avoid the strncpy warnings in this case?
--
Joseph S. Myers
joseph@codesourcery.com