This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] malloc: Add missing arena lock in mallinfo [BZ #22408]


On 11/14/2017 03:39 PM, Siddhesh Poyarekar wrote:
Please add a more verbose description of the problem and the patch in
the git commit message.  I would put the subject line as "Fix arena heap
statistics reporting in malloc_info" since it does more than adding the
missing arena lock.  That or split out the loop to iterate over heaps
into a separate patch since it is a logically distinct change from the
fix to BZ#22408, with a bz to track the fix.  I prefer the latter approach.

Okay, I will send two separate patches. I'm worried it looks like as if I'm fudging the commit statistics.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]