This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 2/5] linux ttyname: Update a reference to kernel docs for kernel 4.10
- From: Christian Brauner <christian dot brauner at mailbox dot org>
- To: Luke Shumaker <lukeshu at parabola dot nu>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 6 Nov 2017 13:44:48 +0100
- Subject: Re: [PATCH v2 2/5] linux ttyname: Update a reference to kernel docs for kernel 4.10
- Authentication-results: sourceware.org; auth=none
- References: <20171102185346.1386-1-lukeshu@parabola.nu> <20171102185346.1386-3-lukeshu@parabola.nu>
On Thu, Nov 02, 2017 at 02:53:43PM -0400, Luke Shumaker wrote:
> Linux 4.10 moved many of the documentation files around.
>
> It came out between the time the patch adding the comment (commit
> 15e9a4f3) was submitted and the time it was applied (in February,
> January, and March 2017; respectively).
> ---
> ChangeLog | 2 ++
> sysdeps/unix/sysv/linux/ttyname.h | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
Reviewed-By: Christian Brauner <christian.brauner@ubuntu.com>
>
> diff --git a/ChangeLog b/ChangeLog
> index f6137669bf..2c7770fbbb 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,7 @@
> 2017-11-02 Luke Shumaker <lukeshu@parabola.nu>
>
> + * sysdeps/unix/sysv/linux/ttyname.h (is_pty): Update doc reference.
> +
> * manual/terminal.texi (Is It a Terminal):
> Mention ENODEV for ttyname and ttyname_r.
>
> diff --git a/sysdeps/unix/sysv/linux/ttyname.h b/sysdeps/unix/sysv/linux/ttyname.h
> index 2e415e4e9c..dd7873d1ff 100644
> --- a/sysdeps/unix/sysv/linux/ttyname.h
> +++ b/sysdeps/unix/sysv/linux/ttyname.h
> @@ -21,7 +21,8 @@
> #include <sys/stat.h>
>
> /* Return true if this is a UNIX98 pty device, as defined in
> - linux/Documentation/devices.txt. */
> + linux/Documentation/devices.txt (on linux < 4.10) or
> + linux/Documentation/admin-guide/devices.txt (on linux >= 4.10). */
> static inline int
> is_pty (struct stat64 *sb)
> {
> --
> 2.15.0
>