This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove unnecessary locking when reading iconv configuration [BZ #22062]
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, Arjun Shankar <arjun dot is at lostca dot se>, libc-alpha at sourceware dot org
- Date: Tue, 31 Oct 2017 21:36:39 -0700
- Subject: Re: [PATCH] Remove unnecessary locking when reading iconv configuration [BZ #22062]
- Authentication-results: sourceware.org; auth=none
- References: <20171026111843.GB79519@aloka.lostca.se> <0afeb00d-f251-379b-e0eb-058d8f052d7a@redhat.com>
On 10/30/2017 09:24 AM, Florian Weimer wrote:
>> - struct path_elem *result;
>
> I think it makes sense to keep the result variable because it can be
> kept in a register across calls. In contrast, the global variable
> has to be reloaded.
What's the difference between loading the value of the global into result
(a register or stack local) and then using it, versus using the value of
the global directly, which gcc will optimize by loading it into a register
or a pseudo (which may be given a stack slot)?
It seems the same to me.
--
Cheers,
Carlos.