This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 02/25] arm: Implement memchr ifunc selection in C


On Thu, 26 Oct 2017, Adhemerval Zanella wrote:

> This patch refactor ARM memchr ifunc selector to a C implementation.
> No functional change is expected, including ifunc resolution rules.
> 
> It also reorganize the ifunc options code:
> 
>   1. The memchr_impl.S is renamed to memchr_neon.S and multiple
>      compilation options (which route to armv6t2/memchr one) is
>      removed.  The code to build if __ARM_NEON__ is defined is
>      also simplified.
> 
>   2. A memchr_noneon is added (which as build along previous ifunc
>      resolution) and includes the armv6t2 direct.
> 
>   3. Same as 2. for loader object.
> 
> Alongside the aforementioned changes, it also some cleanus:
> 
>   - Internal memchr definition (__GI_memcpy) is now a hidden
>     symbol.
>   - No need to create hidden definition for the ifunc variants.
> 
> Checked on armv7-linux-gnueabihf and with a build for arm-linux-gnueabi,
> arm-linux-gnueabihf with and without multiarch support and with both
> GCC 7.1 and GCC mainline.

OK.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]