Re: [PATCH] Reformat sysdeps/x86/libc-start.c

[Carlos O'Donell <carlos at redhat dot com>]

On 10/30/2017 01:42 PM, H.J. Lu wrote:
> On Mon, Oct 30, 2017 at 1:35 PM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 10/30/2017 09:02 PM, H.J. Lu wrote:
>>>
>>> index e11b490f5c..727d328bc7 100644
>>> --- a/sysdeps/x86/libc-start.c
>>> +++ b/sysdeps/x86/libc-start.c
>>> @@ -16,13 +16,13 @@
>>>      <http://www.gnu.org/licenses/>.  */
>>>     #ifndef SHARED
>>> -#include <ldsodefs.h>
>>> +# include <ldsodefs.h>
>>>   # include <cpu-features.h>
>>>   # include <cpu-features.c>
>>>     extern struct cpu_features _dl_x86_cpu_features;
>>>   -#define ARCH_INIT_CPU_FEATURES() init_cpu_features
>>> (&_dl_x86_cpu_features)
>>> +# define ARCH_INIT_CPU_FEATURES() init_cpu_features
>>> (&_dl_x86_cpu_features)
>>>    #endif
>>> -# include <csu/libc-start.c>
>>> +#include <csu/libc-start.c>
>>
>>
>> Maybe add a /* SHARED */ comment on the #endif line while you are at it?
>>
> 
> Sure.  Why not.  I checked in this to add /* !SHARED */.

Should we extend consensus?

https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes
~~~
Anyone can commit a change fixing obvious coding standards problems
in a recently committed patch. Post the patch and ChangeLog to
libc-alpha with a short message and then push the commit. 
~~~
s/a recently/any/g

We normally allow this kind of change for "recently committed"
patches, but shy away from it for older changes because of the impact
it might ave on established code.

In this case I would have liked HJ to be able to just push the cleanup
without anyone *needing* to do a pre-commit review.

-- 
Cheers,
Carlos.