This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Reformat sysdeps/x86/libc-start.c
On Mon, Oct 30, 2017 at 1:35 PM, Florian Weimer <fweimer@redhat.com> wrote:
> On 10/30/2017 09:02 PM, H.J. Lu wrote:
>>
>> index e11b490f5c..727d328bc7 100644
>> --- a/sysdeps/x86/libc-start.c
>> +++ b/sysdeps/x86/libc-start.c
>> @@ -16,13 +16,13 @@
>> <http://www.gnu.org/licenses/>. */
>> #ifndef SHARED
>> -#include <ldsodefs.h>
>> +# include <ldsodefs.h>
>> # include <cpu-features.h>
>> # include <cpu-features.c>
>> extern struct cpu_features _dl_x86_cpu_features;
>> -#define ARCH_INIT_CPU_FEATURES() init_cpu_features
>> (&_dl_x86_cpu_features)
>> +# define ARCH_INIT_CPU_FEATURES() init_cpu_features
>> (&_dl_x86_cpu_features)
>> #endif
>> -# include <csu/libc-start.c>
>> +#include <csu/libc-start.c>
>
>
> Maybe add a /* SHARED */ comment on the #endif line while you are at it?
>
Sure. Why not. I checked in this to add /* !SHARED */.
--
H.J.
From 4ad5106e3b04cc7630f7dbfdb25369807f532843 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 30 Oct 2017 13:39:31 -0700
Subject: [PATCH] sysdeps/x86/libc-start.c: Add /* !SHARED */
* sysdeps/x86/libc-start.c: Add /* !SHARED */.
---
ChangeLog | 4 ++++
sysdeps/x86/libc-start.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 4751a83927..c99898e127 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
2017-10-30 H.J. Lu <hongjiu.lu@intel.com>
+ * sysdeps/x86/libc-start.c: Add /* !SHARED */.
+
+2017-10-30 H.J. Lu <hongjiu.lu@intel.com>
+
* sysdeps/x86/libc-start.c: Reformat.
2017-10-30 H.J. Lu <hongjiu.lu@intel.com>
diff --git a/sysdeps/x86/libc-start.c b/sysdeps/x86/libc-start.c
index 727d328bc7..7a1f51c52e 100644
--- a/sysdeps/x86/libc-start.c
+++ b/sysdeps/x86/libc-start.c
@@ -24,5 +24,5 @@ extern struct cpu_features _dl_x86_cpu_features;
# define ARCH_INIT_CPU_FEATURES() init_cpu_features (&_dl_x86_cpu_features)
-#endif
+#endif /* !SHARED */
#include <csu/libc-start.c>
--
2.13.6