This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] locale: Fix localedef exit code [BZ #22292]
On 10/13/2017 02:41 PM, Carlos O'Donell wrote:
>> I think what you have now is a net improvement, so please go ahead and
>> commit it.
>
> Thanks. Pushed.
This isn't quite the end of the story, and some temporary edits in my tree
hid 3 test failures and one quirk.
I have fixed all of them and pushed it as the fix for this bug.
The fixes are contained to:
localedata/tst-fmon.sh
localedata/tst-locale.sh
The basic problem is that all of the test locales are garbage, and now
that we have fixed the exit code, they all have warnings, and localedef
exits with 1, and the `set -e` kills the test. This is relatively easy
to fix and I included the cleanups for these tests.
The astute reader says "That's not 3!" Well, a failure in tst-locale.sh
fails to build a local later used by tst-digits, so that fixes itself
once you fix tst-locale.sh.
Similarly localedata/gen-locales.sh now accounts for the error
code of 1 from the SHIFT_JIS charmap which is not ISO C compliant and
raises a warning for that, which we now also properly detect.
--
Cheers,
Carlos.