This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] locale: Fix localedef exit code [BZ #22292]
* Carlos O'Donell:
> The static file-scope verbose will have a different definition of
> verbose from the expected verbose used by record-status.h. Thus a
> verbose enablement in locale will not turn on verbose printing in
> record_verbose. There are no such instances of this *today* in
> charmap.c and the other files used by locale AFAICT. So it doesn't
> impact anything, but it should probably be 'int verbose' in
> locale.c, but I'm not sure if I should change that or not, or leave
> it static on purpose.
>
> OK with the above changes *and* leaving locale.c as `static int
> verbose`?
Maybe at a comment on either definition of the verbose variable?
I think what you have now is a net improvement, so please go ahead and
commit it.