This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][malloc] Improve malloc initialization sequence
On Okt 12 2017, Florian Weimer <fweimer@redhat.com> wrote:
> On 10/03/2017 07:18 PM, Wilco Dijkstra wrote:
>> GLIBC builds and tests pass, OK for commit?
>
> The patch was truncated before being attached, it ends with:
>
> @@ -5137,11 +5114,13 @@ __libc_mallopt (int param_number, int value)
> if (__malloc_initialized < 0)
> ptmalloc_init ();
> __libc_lock_lock (av->mutex);
> - /* Ensure initialization/consolidation */
> - malloc_consolidate (av);
> =20
> LIBC_PROBE (memory_mallopt, 2, param_number, value);
> =20
> + /* We must consolidate main arena before changing max_fast
> + (see definition of set_max_fast). */
> + malloc_consolidate (av);
> +
> switch (param_number)
> {
> case M_MXFAST:=
>
> This is not a valid diff hunk (after quoted-printable decoding).
Looks ok to me (9 lines of context, 2-, 4+).
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."