This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Always do locking when iterating over list of streams (bug 15142)


On 10/05/2017 04:51 PM, Andreas Schwab wrote:
On Aug 21 2017, Florian Weimer <fweimer@redhat.com> wrote:

On 08/21/2017 04:22 PM, Andreas Schwab wrote:
	[BZ #15142]
	* libio/genops.c (_IO_list_all_stamp): Delete.  All uses removed.
	(_IO_flush_all_lockp): Always lock list_all_lock.
	(_IO_flush_all_linebuffered): Likewise.
	(_IO_unbuffer_all): Likewise.

This change seems reasonable, but I think we need to remove flushing on
abort first (completely, not the hybrid attempt I posted).

Now that flushing is removed from abort, ok?

Yes, still looks good to me.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]