This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix tests that are testing obsoleted functionality
- From: Steve Ellcey <sellcey at cavium dot com>
- To: Carlos O'Donell <carlos at redhat dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Cc: Florian Weimer <fweimer at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>, nd <nd at arm dot com>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- Date: Tue, 05 Sep 2017 10:49:19 -0700
- Subject: Re: [PATCH] Fix tests that are testing obsoleted functionality
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <1503615332.28672.106.camel@cavium.com> <6025886b-14ab-f188-a2f6-5d5855097efd@redhat.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Thu, 2017-08-24 at 19:11 -0400, Carlos O'Donell wrote:
> On 08/24/2017 06:55 PM, Steve Ellcey wrote:
> >
> > 2017-08-24 Steve Ellcey <sellcey@cavium.com>
> >
> > * include/shlib-compat.h (TEST_COMPAT): New Macro.
> > * malloc/tst-mallocstate.c: Convert from test-skeleton
> > to test-driver. Ifdef code using TEST_COMPAT macro.
> > * math/test-matherr-2.c: Ifdef test using TEST_COMPAT macro.
> > * math/test-matherr.c: Likewise.
> >
> From a high-level perspective this looks good to me.
>
> I know we're not supposed to do anything special on master for
> AArch64 ILP32, but this kind of generic cleanup that future-proofs
> the test for new arches (we are expecting RISC-V port to turn
> up soon and they would have seen this) is a win win.
>
> I'd like one other developer to ACK before you commit this, since
> I'd like to hear a few more opinions on how we might handle this.
Patch ping. Does anyone else have any comments on this approach
to fixing these tests?
Steve Ellcey
sellcey@cavium.com