This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][aarch64] Fix glibc.tune.cpu tunable handling
- From: Steve Ellcey <sellcey at cavium dot com>
- To: Siddhesh Poyarekar <siddhesh at gotplt dot org>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 05 Sep 2017 08:53:54 -0700
- Subject: Re: [PATCH][aarch64] Fix glibc.tune.cpu tunable handling
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <1504294850.3182.66.camel@cavium.com> <18df4eef-a7ee-2cd8-05da-00b446d14c25@gotplt.org>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Mon, 2017-09-04 at 11:07 +0530, Siddhesh Poyarekar wrote:
>
> Right, tunable_is_name is the wrong function to call but using strcmp
> there may not be safe. Please verify that it does not go through a PLT,
> i.e. it calls the ld.so version at all times.
>
> Siddhesh
I am not sure I know how to do this. If I look at csu/libc-start.o,
where, after inlining, this code shows up I see a reference to "strcmp"
and not to "__GI_strcmp" that I see in some other places. Does that
mean I am going through the PLT? If so, what do I do about it? I also
see a new undefined reference to strcmp from elf/dl-sysdep.os, but that
file was already referencing "strlen", so maybe it doesn't matter
there.
Steve Ellcey
sellcey@cavium.com