Re: [PATCH] malloc: Use compat_symbol_reference in libmcheck [BZ #22050]

[Florian Weimer <fweimer at redhat dot com>]

On 08/31/2017 05:42 PM, Zack Weinberg wrote:
> On Thu, Aug 31, 2017 at 11:37 AM, Carlos O'Donell <carlos@redhat.com> wrote:
>> I would like to see a new macro that does what it says, rather than use the
>> existing macro in the wrong way. Even if the new macro is just a copy.
>>
>> This looks like a real problem for glibc, particularly if we need to continue
>> to use, at least internally, certain old versions of symbols. So having a
>> new macro for this is fine.
> 
> I see immediate uses for this macro in the test suite, verifying that
> compat symbols continue to work correctly...  (particularly thinking
> of the messy and totally untested old-FILE support).

That's the exact purpose of compat_symbol_reference.  I think Carlos is
objecting to its use for a *definition*.

Thanks,
Florian