This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] dynarray: Set errno on overflow-induced allocation failure
- From: Florian Weimer <fweimer at redhat dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 30 Aug 2017 19:56:31 +0200
- Subject: Re: [PATCH] dynarray: Set errno on overflow-induced allocation failure
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E96038046A
- References: <xnfuc9c586.fsf@greed.delorie.com>
On 08/30/2017 07:53 PM, DJ Delorie wrote:
>
> Looks good to me, although I wonder if ENOMEM is the right error - is it
> really a lack of memory, or is it an invalid parameter (EDOM,
> EOVERFLOW)?
calloc and malloc return ENOMEM in this situation, too.
Thanks,
Florian