This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][AArch64] Fix elf_greg_t on ILP32
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: nd at arm dot com, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 29 Aug 2017 16:42:30 +0100
- Subject: Re: [PATCH][AArch64] Fix elf_greg_t on ILP32
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <599DB988.7040501@arm.com> <59A58196.1040206@arm.com> <CAKCAbMiD_W0W1_n-Xm5k1jAvn1+0-FT5BQrUpi9KUoE5eucsaQ@mail.gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 29/08/17 16:20, Zack Weinberg wrote:
> On Tue, Aug 29, 2017 at 11:00 AM, Szabolcs Nagy <szabolcs.nagy@arm.com> wrote:
>> On 23/08/17 18:21, Szabolcs Nagy wrote:
>>> Use uint64_t instead of unsigned long.
>>>
>>> will commit it tomorrow if there are no objections.
>>>
>>> ChangleLog:
>>> 2017-08-23 Szabolcs Nagy <szabolcs.nagy@arm.com>
>>>
>>> * sysdeps/unix/sysv/linux/aarch64/sys/procfs.h (elf_greg_t):
>>> Use uint64_t instead of unsigned long.
>>>
>>
>> hm sys/procfs.h is included into signal.h
>> via sys/ucontext.h, where stdint.h should
>> not be exposed..
>
> sys/procfs.h already includes sys/types.h, so use __uint64_t.
>
ah thanks, that works.
> Why does sys/ucontext.h need to include sys/procfs.h?
>
it defines elf_*_t which is used in ucontext.h as
#ifdef __USE_MISC
# include <sys/procfs.h>
typedef elf_greg_t greg_t;
/* Container for all general registers. */
typedef elf_gregset_t gregset_t;
/* Structure to describe FPU registers. */
typedef elf_fpregset_t fpregset_t;
#endif