This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2 v2] openpty: use TIOCGPTPEER to open slave side fd


On Aug 28 2017, Christian Brauner <christian.brauner@ubuntu.com> wrote:

> diff --git a/login/openpty.c b/login/openpty.c
> index 8fbc66a3ef..43b34d7a9c 100644
> --- a/login/openpty.c
> +++ b/login/openpty.c
> @@ -87,9 +87,9 @@ openpty (int *amaster, int *aslave, char *name,
>  	 const struct termios *termp, const struct winsize *winp)
>  {
>  #ifdef PATH_MAX
> -  char _buf[PATH_MAX];
> +  char _buf[PATH_MAX] = {0};
>  #else
> -  char _buf[512];
> +  char _buf[512] = {0};
>  #endif

No need to clear the whole array, just the first byte.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]