This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Enable hidden visibility in libc.a compiled with PIE
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 21 Aug 2017 17:48:03 +0200
- Subject: Re: [PATCH] Enable hidden visibility in libc.a compiled with PIE
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EF5D6C05680C
- References: <20170808164040.GA31184@gmail.com>
On 08/08/2017 06:40 PM, H.J. Lu wrote:
> -#if defined SHARED || defined LIBC_NONSHARED
> +#if defined SHARED || defined LIBC_NONSHARED \
> + || (BUILD_PIE_DEFAULT && IS_IN (libc))
> # define attribute_hidden __attribute__ ((visibility ("hidden")))
> #else
> # define attribute_hidden
I think this broke “make subdirs=benchtests bench-build” because
json-lib.c is erroneously compiled with -DMODULE_NAME=libc.
Thanks,
Florian